aboutsummaryrefslogtreecommitdiff
path: root/handler.go (follow)
Commit message (Collapse)AuthorAgeFiles
* refactor(packageHandler): Don't retain configuration (#85)Abhinav Gupta2023-04-281
| | | | | | | | | This patch removes the need to retain the configuration in the packageHandler struct. Instead, it retains only the fields that are required for the handler to function. This also allows us to pre-compute the canonical import path rather than calculating it on the request path.
* config: Rename Package to PackageConfig, add docs (#84)Abhinav Gupta2023-04-281
| | | | | | | | | | | Renames the Package struct to PackageConfig to make it clear that it is a configuration struct. This differentiation will help disconnect the configuration-level representation from the runtime representation of this information. This patch also adds documentation to the config package that was previously missing.
* Drop httprouter dependency (#71)Abhinav Gupta2023-01-231
| | | | | | | | | | | | | | This drops the third-party HTTP router dependency. This dependency wasn't strictly necessary since our routing needs are quite basic: - `/$name` and `/$name/*` for all registered packages - `/` for root This is easily accomplished with `http.ServeMux`: - register `/$name` and `/$name/`. The latter will receive all subpackage requests. - register `/` and reject anything that isn't for exactly `/`.
* Support package-level overrides for URLs (#52)Tyler Sullivan2022-01-031
| | | | | | | | | | | | | | | | | | Sally accepts the base vanity URL (e.g. `go.uber.org`) in a top-level `url` key. This applies to all packages listed in the configuration. Add support for overriding the `url` on a per-package basis. This will provide for an easier transition period when migrating Go packages of an organization between hosts, for example from BitBucket to GitHub. With this, source code can be modified across the various repositories over time to use the new vanity URL. For example, some packages will use a URL of bitbucketurl.org and some will use mycoolgoimportvanity.org in their source code imports. Other than the use-case outlined above, this feature adds flexibility to the vanity server to support more than one vanity URL when used behind an ingress controller.
* Use go embed for templates (#50)Luciano Nooijen2021-09-101
| | | | | | | | Go 1.16 includes a `//go:embed` directive that obviates the need for bindata. Use `//go:embed` instead of bindata for templates used in sally. Signed-off-by: Luciano Nooijen <luciano@bytecode.nl> Co-authored-by: Abhinav Gupta <abg@uber.com>
* Allow setting branch (#46)Jan-Philipp Benecke2021-05-181
| | | | Support specifying the branch from which source will be served in the YAML configuration.
* Support changing godoc instance (#38)Diego Bernardes2019-03-051
| | | | | This adds the ability to change the godoc.org instance used by Sally to link to documentation by providing a new `godoc` section in the configuration.
* template: Bundle in binary with bindata (#36)Abhinav Gupta2019-01-031
| | | | | | | | This uses go-bindata/go-bindata to bundle the template in the binary. I also realized that the handler test was now broken because we were checking the exact contents of the index page in the test. This change fixes that too.
* Add minimal stylingAbhinav Gupta2019-01-031
|
* Enforce alphabetical ordering of packages in YAML config (#22)Garrett Squire2016-10-271
|
* Rework as HTTP server (#15)Grayson Koonce2016-10-121