<feed xmlns='http://www.w3.org/2005/Atom'>
<title>sally/Makefile, branch grumps-build</title>
<subtitle>a fork with reasonable build of uber-go/sally</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/'/>
<entry>
<title>feat: add grumps build</title>
<updated>2024-09-06T05:10:36+00:00</updated>
<author>
<name>Max Resnick</name>
<email>max@ofmax.li</email>
</author>
<published>2024-09-06T05:10:36+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=9b81c20dac38efdcfe9ea8455ec0e443b4b642ac'/>
<id>9b81c20dac38efdcfe9ea8455ec0e443b4b642ac</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>ci: Use golangci-lint for linting (#121)</title>
<updated>2023-10-21T23:59:14+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>mail@abhinavg.net</email>
</author>
<published>2023-10-21T23:59:14+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=4fe6763faf645568b2d1d3fe4cdcfcf6b12cf7e6'/>
<id>4fe6763faf645568b2d1d3fe4cdcfcf6b12cf7e6</id>
<content type='text'>
Instead of hand-managing and running linters, use golangci-lint.

Along with the golangci-lint defaults,
enable a couple other linters we generally agree with.
See also uber-go/zap#1323 for a similar change.

As a result of this, we can:

- Drop the dependabot for tools
- Run the lint job in parallel with build/test
- Simplify the Makefile</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of hand-managing and running linters, use golangci-lint.

Along with the golangci-lint defaults,
enable a couple other linters we generally agree with.
See also uber-go/zap#1323 for a similar change.

As a result of this, we can:

- Drop the dependabot for tools
- Run the lint job in parallel with build/test
- Simplify the Makefile</pre>
</div>
</content>
</entry>
<entry>
<title>ci: gofmt, golint =&gt; revive, update tools and actions (#87)</title>
<updated>2023-04-29T18:48:57+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>mail@abhinavg.net</email>
</author>
<published>2023-04-29T18:48:57+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=83efe3481a5c001ae37116e8a5b0240552fa6c04'/>
<id>83efe3481a5c001ae37116e8a5b0240552fa6c04</id>
<content type='text'>
Fixes up the `make lint` target to also check
that all files are properly gofmt-ed,
replaces the deprecated `golint` check with `revive`,
and sets up dependabot to also update tools and actions regularly.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes up the `make lint` target to also check
that all files are properly gofmt-ed,
replaces the deprecated `golint` check with `revive`,
and sets up dependabot to also update tools and actions regularly.</pre>
</div>
</content>
</entry>
<entry>
<title>Makefile: Simplify (#62)</title>
<updated>2022-12-19T07:01:59+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>mail@abhinavg.net</email>
</author>
<published>2022-12-19T07:01:59+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=e3604e558f6bd4dccc96b9bd071223fd8506888f'/>
<id>e3604e558f6bd4dccc96b9bd071223fd8506888f</id>
<content type='text'>
This simplifies the Makefile significantly,
borrowing patterns we've used in other projects.
Namely:

- Set GOBIN to a bin subdirectory
  so that we can `go install` dependencies into it.
- Use a shared TEST_FLAGS for `make test` and `make cover`.
  Without this, we're not running with data race detection in CI.
- Build lint step out of separate golint and staticcheck steps.
  In the future, a gofmt step may also be added.
- Move tools dependencies into an unpublished subpackage.

Note: I didn't mess with the 'clean' and 'run' targets
at the bottom of the file even though they're not necessary
to avoid a merge conflict with #60.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This simplifies the Makefile significantly,
borrowing patterns we've used in other projects.
Namely:

- Set GOBIN to a bin subdirectory
  so that we can `go install` dependencies into it.
- Use a shared TEST_FLAGS for `make test` and `make cover`.
  Without this, we're not running with data race detection in CI.
- Build lint step out of separate golint and staticcheck steps.
  In the future, a gofmt step may also be added.
- Move tools dependencies into an unpublished subpackage.

Note: I didn't mess with the 'clean' and 'run' targets
at the bottom of the file even though they're not necessary
to avoid a merge conflict with #60.</pre>
</div>
</content>
</entry>
<entry>
<title>Delete unused Docker infrastructure (#60)</title>
<updated>2022-12-19T07:01:01+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>mail@abhinavg.net</email>
</author>
<published>2022-12-19T07:01:01+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=47a726398b055cf77df38addf90a1a388a53b2c7'/>
<id>47a726398b055cf77df38addf90a1a388a53b2c7</id>
<content type='text'>
This was all added back when these tests were running on Travis CI
and attempted to create an isolated build of sally.

This is all no longer necessary because GitHub Actions and Go modules
provide enough isolation.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was all added back when these tests were running on Travis CI
and attempted to create an isolated build of sally.

This is all no longer necessary because GitHub Actions and Go modules
provide enough isolation.</pre>
</div>
</content>
</entry>
<entry>
<title>Update dependencies (#54)</title>
<updated>2022-05-17T16:43:31+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>abg@uber.com</email>
</author>
<published>2022-05-17T16:43:31+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=c40da362956f3f18fdcb3a86c0b7f000f54bf909'/>
<id>c40da362956f3f18fdcb3a86c0b7f000f54bf909</id>
<content type='text'>
Update all dependencies,
use Go 1.18 to build and test,
and delete outdated `bindata` clause in Makefile
(we switched to `go:embed` in #50).

Other minor changes:

- Fix the golint import path
  (it switched to golang.org/x/lint long before it was deprecated)
  and fix the failing lint check.
  (Switching from golint to revive is out of scope for this PR.)
- Delete .envrc -- this was transitional for when Go modules were
  optional.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update all dependencies,
use Go 1.18 to build and test,
and delete outdated `bindata` clause in Makefile
(we switched to `go:embed` in #50).

Other minor changes:

- Fix the golint import path
  (it switched to golang.org/x/lint long before it was deprecated)
  and fix the failing lint check.
  (Switching from golint to revive is out of scope for this PR.)
- Delete .envrc -- this was transitional for when Go modules were
  optional.</pre>
</div>
</content>
</entry>
<entry>
<title>Use go embed for templates (#50)</title>
<updated>2021-09-10T22:57:07+00:00</updated>
<author>
<name>Luciano Nooijen</name>
<email>luciano@bytecode.nl</email>
</author>
<published>2021-09-10T22:57:07+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=dd62ebd406a23184ec072d38894a5a3aac141b0d'/>
<id>dd62ebd406a23184ec072d38894a5a3aac141b0d</id>
<content type='text'>
Go 1.16 includes a `//go:embed` directive that obviates the need for
bindata. Use `//go:embed` instead of bindata for templates used in
sally.

Signed-off-by: Luciano Nooijen &lt;luciano@bytecode.nl&gt;
Co-authored-by: Abhinav Gupta &lt;abg@uber.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Go 1.16 includes a `//go:embed` directive that obviates the need for
bindata. Use `//go:embed` instead of bindata for templates used in
sally.

Signed-off-by: Luciano Nooijen &lt;luciano@bytecode.nl&gt;
Co-authored-by: Abhinav Gupta &lt;abg@uber.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>Set up CI (#45)</title>
<updated>2021-05-17T22:14:22+00:00</updated>
<author>
<name>Dmitriy Shirchenko</name>
<email>shirchen@users.noreply.github.com</email>
</author>
<published>2021-05-17T22:14:22+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=b627e361379b89802df4930abbc64ce26bd8f323'/>
<id>b627e361379b89802df4930abbc64ce26bd8f323</id>
<content type='text'>
Set up CI with GitHub actions.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Set up CI with GitHub actions.</pre>
</div>
</content>
</entry>
<entry>
<title>template: Bundle in binary with bindata (#36)</title>
<updated>2019-01-03T21:55:15+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>mail@abhinavg.net</email>
</author>
<published>2019-01-03T21:55:15+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=2bf0f688f895aa19f976051e30b967a6187e27b4'/>
<id>2bf0f688f895aa19f976051e30b967a6187e27b4</id>
<content type='text'>
This uses go-bindata/go-bindata to bundle the template in the binary.

I also realized that the handler test was now broken because we were
checking the exact contents of the index page in the test. This change
fixes that too.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This uses go-bindata/go-bindata to bundle the template in the binary.

I also realized that the handler test was now broken because we were
checking the exact contents of the index page in the test. This change
fixes that too.
</pre>
</div>
</content>
</entry>
<entry>
<title>Upgrade to Go 1.11 and use modules (#33)</title>
<updated>2019-01-03T00:36:04+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>mail@abhinavg.net</email>
</author>
<published>2019-01-03T00:36:04+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=fa1cf198a7c22a0f7537c565e36a19567bbde0d8'/>
<id>fa1cf198a7c22a0f7537c565e36a19567bbde0d8</id>
<content type='text'>
This commit modernizes the repository organization a bit.

In short, this,

- Upgrades to Go 1.11.
- Uses Go modules instead of Glide.
- Drops errcheck, which we rarely use in our codebase internally.
- Uses `./...` to run build, tests, etc. since that does not have to
  account for vendor anymore.
- Drops `-installsuffix cgo` from the production build. This was a
  workaround for pre-1.10 versions of Go. See
  https://github.com/golang/go/issues/9344#issuecomment-69944514.
- Uses a tools.go as recommended in [go-modules-by-example/tools][1] to
  pin to tool dependencies.
- Uses `go run` instead of `go install`ing tools globally.

[1]: https://github.com/go-modules-by-example/index/tree/master/010_tools

Tested locally with `make docker-launch`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit modernizes the repository organization a bit.

In short, this,

- Upgrades to Go 1.11.
- Uses Go modules instead of Glide.
- Drops errcheck, which we rarely use in our codebase internally.
- Uses `./...` to run build, tests, etc. since that does not have to
  account for vendor anymore.
- Drops `-installsuffix cgo` from the production build. This was a
  workaround for pre-1.10 versions of Go. See
  https://github.com/golang/go/issues/9344#issuecomment-69944514.
- Uses a tools.go as recommended in [go-modules-by-example/tools][1] to
  pin to tool dependencies.
- Uses `go run` instead of `go install`ing tools globally.

[1]: https://github.com/go-modules-by-example/index/tree/master/010_tools

Tested locally with `make docker-launch`.
</pre>
</div>
</content>
</entry>
</feed>
