<feed xmlns='http://www.w3.org/2005/Atom'>
<title>sally/Dockerfile, branch CHECKPOINT</title>
<subtitle>a fork with reasonable build of uber-go/sally</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/'/>
<entry>
<title>Use Go 1.22</title>
<updated>2024-04-29T19:06:55+00:00</updated>
<author>
<name>Chongyi Zheng</name>
<email>git@zcy.dev</email>
</author>
<published>2024-02-26T02:55:48+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=6d9d500de946d5b992804b4208449fc741f68e26'/>
<id>6d9d500de946d5b992804b4208449fc741f68e26</id>
<content type='text'>
This upgrades sally to use Go 1.22.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This upgrades sally to use Go 1.22.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for sub-indexes (#120)</title>
<updated>2023-10-18T22:18:40+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>mail@abhinavg.net</email>
</author>
<published>2023-10-18T22:18:40+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=5fbb57ed966154dc29730e0ce62824e1b577d8cb'/>
<id>5fbb57ed966154dc29730e0ce62824e1b577d8cb</id>
<content type='text'>
&lt;details&gt;
&lt;summary&gt;Background&lt;/summary&gt;

Sally renders two kinds of pages:

- packages: These are for packages defined in sally.yaml
  and any route under the package path.
- indexes: These list available packages.

The latter--indexes was previously only supported at '/', the root page.

This leads to a slight UX issue:
if you have a package with a / in its name (e.g. net/metrics):

- example.com/net/metrics gives you the package page
- example.com/ lists net/metrics
- However, example.com/net fails with a 404

&lt;/details&gt;

This adds support for index pages on all parents of package pages.
Therefore, if example.com/net/metrics exists,
example.com/net will list all packages defined under that path.

Resolves #31
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
&lt;details&gt;
&lt;summary&gt;Background&lt;/summary&gt;

Sally renders two kinds of pages:

- packages: These are for packages defined in sally.yaml
  and any route under the package path.
- indexes: These list available packages.

The latter--indexes was previously only supported at '/', the root page.

This leads to a slight UX issue:
if you have a package with a / in its name (e.g. net/metrics):

- example.com/net/metrics gives you the package page
- example.com/ lists net/metrics
- However, example.com/net fails with a 404

&lt;/details&gt;

This adds support for index pages on all parents of package pages.
Therefore, if example.com/net/metrics exists,
example.com/net will list all packages defined under that path.

Resolves #31
</pre>
</div>
</content>
</entry>
<entry>
<title>Add minimal Dockerfile (#72)</title>
<updated>2023-01-23T18:43:39+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>mail@abhinavg.net</email>
</author>
<published>2023-01-23T18:43:39+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=6b99960380132dc92837e7a67e95901e144e38b0'/>
<id>6b99960380132dc92837e7a67e95901e144e38b0</id>
<content type='text'>
Adds a Dockerfile that builds sally using a phased Docker build.
The first phase builds sally,
and the second phase publishes a scratch image
with just sally.

If Uber publishes this to a container registry,
a user can use it like so:

    % vim sally.yaml # create a sally yaml
    % cat &gt; Dockerfile
    FROM sally:latest
    COPY sally.yaml /sally.yaml
    % docker build .

Even without publishing, this provides an example
of how to build sally for deployment.

Testing:
I verified the instructions above locally
by tagging locally with:

    % docker build -t sally:latest

I'm also using a variation of this Dockerfile in production
right now for my own hosted instance of sally.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds a Dockerfile that builds sally using a phased Docker build.
The first phase builds sally,
and the second phase publishes a scratch image
with just sally.

If Uber publishes this to a container registry,
a user can use it like so:

    % vim sally.yaml # create a sally yaml
    % cat &gt; Dockerfile
    FROM sally:latest
    COPY sally.yaml /sally.yaml
    % docker build .

Even without publishing, this provides an example
of how to build sally for deployment.

Testing:
I verified the instructions above locally
by tagging locally with:

    % docker build -t sally:latest

I'm also using a variation of this Dockerfile in production
right now for my own hosted instance of sally.</pre>
</div>
</content>
</entry>
<entry>
<title>Delete unused Docker infrastructure (#60)</title>
<updated>2022-12-19T07:01:01+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>mail@abhinavg.net</email>
</author>
<published>2022-12-19T07:01:01+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=47a726398b055cf77df38addf90a1a388a53b2c7'/>
<id>47a726398b055cf77df38addf90a1a388a53b2c7</id>
<content type='text'>
This was all added back when these tests were running on Travis CI
and attempted to create an isolated build of sally.

This is all no longer necessary because GitHub Actions and Go modules
provide enough isolation.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was all added back when these tests were running on Travis CI
and attempted to create an isolated build of sally.

This is all no longer necessary because GitHub Actions and Go modules
provide enough isolation.</pre>
</div>
</content>
</entry>
<entry>
<title>Update dependencies (#54)</title>
<updated>2022-05-17T16:43:31+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>abg@uber.com</email>
</author>
<published>2022-05-17T16:43:31+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=c40da362956f3f18fdcb3a86c0b7f000f54bf909'/>
<id>c40da362956f3f18fdcb3a86c0b7f000f54bf909</id>
<content type='text'>
Update all dependencies,
use Go 1.18 to build and test,
and delete outdated `bindata` clause in Makefile
(we switched to `go:embed` in #50).

Other minor changes:

- Fix the golint import path
  (it switched to golang.org/x/lint long before it was deprecated)
  and fix the failing lint check.
  (Switching from golint to revive is out of scope for this PR.)
- Delete .envrc -- this was transitional for when Go modules were
  optional.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update all dependencies,
use Go 1.18 to build and test,
and delete outdated `bindata` clause in Makefile
(we switched to `go:embed` in #50).

Other minor changes:

- Fix the golint import path
  (it switched to golang.org/x/lint long before it was deprecated)
  and fix the failing lint check.
  (Switching from golint to revive is out of scope for this PR.)
- Delete .envrc -- this was transitional for when Go modules were
  optional.</pre>
</div>
</content>
</entry>
<entry>
<title>Use Go 1.17 to test and build (#51)</title>
<updated>2021-09-08T18:09:26+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>abg@uber.com</email>
</author>
<published>2021-09-08T18:09:26+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=68f125ff5e3042610be114899531d73137726027'/>
<id>68f125ff5e3042610be114899531d73137726027</id>
<content type='text'>
sally is not a library, so there's no reason to test it with two
versions of Go.

Use the latest version of Go to build and test it.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
sally is not a library, so there's no reason to test it with two
versions of Go.

Use the latest version of Go to build and test it.</pre>
</div>
</content>
</entry>
<entry>
<title>Upgrade to Go 1.11 and use modules (#33)</title>
<updated>2019-01-03T00:36:04+00:00</updated>
<author>
<name>Abhinav Gupta</name>
<email>mail@abhinavg.net</email>
</author>
<published>2019-01-03T00:36:04+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=fa1cf198a7c22a0f7537c565e36a19567bbde0d8'/>
<id>fa1cf198a7c22a0f7537c565e36a19567bbde0d8</id>
<content type='text'>
This commit modernizes the repository organization a bit.

In short, this,

- Upgrades to Go 1.11.
- Uses Go modules instead of Glide.
- Drops errcheck, which we rarely use in our codebase internally.
- Uses `./...` to run build, tests, etc. since that does not have to
  account for vendor anymore.
- Drops `-installsuffix cgo` from the production build. This was a
  workaround for pre-1.10 versions of Go. See
  https://github.com/golang/go/issues/9344#issuecomment-69944514.
- Uses a tools.go as recommended in [go-modules-by-example/tools][1] to
  pin to tool dependencies.
- Uses `go run` instead of `go install`ing tools globally.

[1]: https://github.com/go-modules-by-example/index/tree/master/010_tools

Tested locally with `make docker-launch`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit modernizes the repository organization a bit.

In short, this,

- Upgrades to Go 1.11.
- Uses Go modules instead of Glide.
- Drops errcheck, which we rarely use in our codebase internally.
- Uses `./...` to run build, tests, etc. since that does not have to
  account for vendor anymore.
- Drops `-installsuffix cgo` from the production build. This was a
  workaround for pre-1.10 versions of Go. See
  https://github.com/golang/go/issues/9344#issuecomment-69944514.
- Uses a tools.go as recommended in [go-modules-by-example/tools][1] to
  pin to tool dependencies.
- Uses `go run` instead of `go install`ing tools globally.

[1]: https://github.com/go-modules-by-example/index/tree/master/010_tools

Tested locally with `make docker-launch`.
</pre>
</div>
</content>
</entry>
<entry>
<title>bump golang version in Dockerfile (#29)</title>
<updated>2017-01-31T23:47:29+00:00</updated>
<author>
<name>Peter Edge</name>
<email>peter.edge@gmail.com</email>
</author>
<published>2017-01-31T23:47:29+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=d7723f129c89c90c19e4eee8e7d7ce543d6cb6cc'/>
<id>d7723f129c89c90c19e4eee8e7d7ce543d6cb6cc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add dockerfiles and update makefile (#25)</title>
<updated>2017-01-26T19:32:21+00:00</updated>
<author>
<name>Peter Edge</name>
<email>peter.edge@gmail.com</email>
</author>
<published>2017-01-26T19:32:21+00:00</published>
<link rel='alternate' type='text/html' href='http://cgit.ofmax.li/sally/commit/?id=10d8a723b116b6ee54d57363c9eaebe9eaa71f4f'/>
<id>10d8a723b116b6ee54d57363c9eaebe9eaa71f4f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
